[PATCH v2 1/1] arm64: zynqmp: Add output-enable pins to SOMs

Frager, Neal neal.frager at amd.com
Thu Dec 14 17:19:45 CET 2023


Hi Michal,

> Now that the zynqmp pinctrl driver supports the tri-state registers, make
> sure that the pins requiring output-enable are configured appropriately for
> SOMs.
> 
> Without it, all tristate setting for MIOs, which are not related to SOM
> itself, are using default configuration which is not correct setting.
> It means SDs, USBs, ethernet, etc. are not working properly.
> 
> In past it was fixed through calling tristate configuration via bootcmd:
> usb_init=mw 0xFF180208 2020
> kv260_gem3=mw 0xFF18020C 0xFC0 && gpio toggle gpio at ff0a000038 && \
>    gpio toggle gpio at ff0a000038
> 
> Signed-off-by: Neal Frager <neal.frager at amd.com>
> ---
> V1->V2:
>   - remove output-enable from gem1 conf-rx pins
> ---
>   arch/arm/dts/zynqmp-sck-kd-g-revA.dts | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/dts/zynqmp-sck-kd-g-revA.dts b/arch/arm/dts/zynqmp-sck-kd-g-revA.dts
> index 56f3128528..12865392a3 100644
> --- a/arch/arm/dts/zynqmp-sck-kd-g-revA.dts
> +++ b/arch/arm/dts/zynqmp-sck-kd-g-revA.dts

> This file never gets to upstream because it was merged as dtso.
> That's why I think you are not using the latest tree for this patch.
> Can you please rebase and send again?

Thank you for pointing this out.

You are correct as I was actually working from the
https://github.com/Xilinx/u-boot-xlnx/ master branch
which, as you know, is still based on u-boot 2023.01.

Looking at the upstream zynqmp-sck-kd-g-revA.dtso,
the output-enable defines are already included, so this
patch is unnecessary.

Please disregard this patch.  I will mark it as handled
elsewhere.

Best regards,
Neal Frager
AMD


More information about the U-Boot mailing list