[PATCH v1 1/1] arm64: zynqmp: Fix k24 psu_init_gpl.c clocking

[Frager, Neal]

Hi Michal,

> This patch corrects the k24 som clocking configuration such that the serdes

> Corrects the ...

Ok.

> clocks are correctly enabled and the usb0 is configured to use the psgtr
> refclk2 for usb3 mode.

> I sort of have no problem with this patch but it should be better described.
> Pretty much serdes configuration should be called from u-boot because we already 
> have psgtr driver and usb3.0 can be configured out of it.
> But we can't touch dwc3 driver now that's why the only way to do it is to 
> configure via psu_init.
> But it should be clear from commit message that it is workaround not really 
> something what should be here.

I will re-test this without the serdes additions to see if they are
really necessary.

> This patch also corrects the configuration of mio pins mio76 and mio77
> which should be configured as gpio pins.

> This is definitely fine.

Good.

> 
> Signed-off-by: Neal Frager <neal.frager at amd.com>

> You mentioned that SPL didn't work before. Is it because of incorrect serdes 
> configuration? Because that's sounds weird because you don't need serdes 
> initialization for booting out of qspi. That's why looking for which is that bit 
> which make SPL work on KD240.

The SPL works.  The issue is the same as I had with the kr260
board.  The sd card interface is over usb, so unless the usb3
works correctly, u-boot has no sd card interface and cannot
find the Linux kernel and file system.

So what I meant was that I cannot boot up properly
when starting from the SPL.  This is what this patch is
meant to fix.

> ---
>   .../zynqmp/zynqmp-sm-k24-revA/psu_init_gpl.c  | 266 +++++++++++++-----
>   1 file changed, 200 insertions(+), 66 deletions(-)

> This patch is not based on the latest tree.
> There is 0a965b10e2413989e351b5a5b49737babdf5b751 in the middle that's why 
> please rebase.

Yes, I will switch over, as I did not realize that this file was not
the same in the u-boot-xlnx and upstream trees.

Best regards,
Neal Frager
AMD