[PATCH] spi: cadence-quadspi: Fix error message on stuck busy state

[Jan Kiszka]

On 31.10.23 08:14, Stefan Roese wrote:
> On 10/30/23 17:20, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka at siemens.com>
>>
>> We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since
>> day 1.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
> 
> Reviewed-by: Stefan Roese <sr at denx.de>
> 
> Thanks,
> Stefan
> 
>> ---
>>
>> We are unfortunately seeing that message right now, rarely but then
>> prominently...
>>
>>   drivers/spi/cadence_qspi_apb.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/spi/cadence_qspi_apb.c
>> b/drivers/spi/cadence_qspi_apb.c
>> index 9ce2c0f254f..d033184aa46 100644
>> --- a/drivers/spi/cadence_qspi_apb.c
>> +++ b/drivers/spi/cadence_qspi_apb.c
>> @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void
>> *reg_base)
>>       }
>>         /* Timeout, still in busy mode. */
>> -    printf("QSPI: QSPI is still busy after poll for %d times.\n",
>> -           CQSPI_REG_RETRY);
>> +    printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout);
>>       return 0;
>>   }
>>   
> 
> Viele Grüße,
> Stefan Roese
> 

Ping.

Jan

-- 
Siemens AG, Technology
Linux Expert Center