[PATCH 1/1] Makefile: pass -ansi option to cmd_gen_envp

Sébastien Szymanski sebastien.szymanski at armadeus.com
Fri Dec 15 14:25:33 CET 2023


Hi Fabio,

On 12/15/23 13:03, Fabio Estevam wrote:
> Hi Sébastien,
> 
> On Fri, Dec 15, 2023 at 8:14 AM Sébastien Szymanski
> <sebastien.szymanski at armadeus.com> wrote:
> 
>> --- a/board/siemens/iot2050/iot2050.env
>> +++ b/board/siemens/iot2050/iot2050.env
>> @@ -1,4 +1,4 @@
>> -// SPDX-License-Identifier: GPL-2.0+
>> +/* SPDX-License-Identifier: GPL-2.0+ */
> 

With the -ansi option, the C++ style comments make an error:

include/generated/env.txt:1:1: error: C++ style comments are not allowed 
in ISO C90
     1 | // SPDX-License-Identifier: GPL-2.0+

I should have mention that in my commit log.

Regards,

> This is an unrelated change.
> 
>>   /*
>>    * Copyright (c) Siemens AG, 2023
>>    *
>> diff --git a/board/storopack/smegw01/smegw01.env b/board/storopack/smegw01/smegw01.env
>> index 93de8669109d..6807ada71887 100644
>> --- a/board/storopack/smegw01/smegw01.env
>> +++ b/board/storopack/smegw01/smegw01.env
>> @@ -1,4 +1,4 @@
>> -// SPDX-License-Identifier: GPL-2.0+
>> +/* SPDX-License-Identifier: GPL-2.0+ */
> 
> Same here.

-- 
Sébastien Szymanski, Armadeus Systems
Software engineer



More information about the U-Boot mailing list