[PATCH v2 08/16] fastboot: Remove dependencies on CMDLINE

Tom Rini trini at konsulko.com
Fri Dec 15 14:49:24 CET 2023


On Thu, Dec 14, 2023 at 09:19:06PM -0700, Simon Glass wrote:
> It is possible to boot a kernel without CMDLINE being enabled. Update
> the implementation to handle this, and drop the condition from the
> FASTBOOT config.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v2:
> - Avoid changing the logic when a command is not set
> 
>  drivers/fastboot/Kconfig     |  1 -
>  drivers/fastboot/fb_common.c | 30 ++++++++++++++----------------
>  2 files changed, 14 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
> index 11fc0fe1c800..837c6f1180da 100644
> --- a/drivers/fastboot/Kconfig
> +++ b/drivers/fastboot/Kconfig
> @@ -1,5 +1,4 @@
>  menu "Fastboot support"
> -	depends on CMDLINE
>  
>  config FASTBOOT
>  	bool

Please expand the help to note that CMDLINE is recommended and that the
more complex use cases that require running additional commands rather
than simply booting the OS will not work without CMDLINE, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231215/f24d5f5f/attachment.sig>


More information about the U-Boot mailing list