[PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list

Andy Shevchenko andriy.shevchenko at linux.intel.com
Fri Dec 15 18:46:53 CET 2023


On Fri, Dec 15, 2023 at 05:40:16PM +0100, Heinrich Schuchardt wrote:
> On non x86 platforms the hardware reduce flag must be set in the FADT
> table. Write an error message if the flag is missing.

...

> +	if (!IS_ENABLED(CONFIG_X86) &&
> +	    !(fadt->flags & ACPI_FADT_HW_REDUCED_ACPI))
> +		log_err("FADT not ACPI hardware reduced compliant\n");

I guess it's half baked solution as this, HW reduced, flag adds more
limitations even on x86. If you want a good validation it should be done
in a separate function taking others aspects into account.

But since it doesn't affect my area of interest in U-Boot, I won't prevent
you from doing this way, it's up to the U-Boot maintainers how to proceed
with it.

-- 
With Best Regards,
Andy Shevchenko




More information about the U-Boot mailing list