[PATCH v2 3/9] arrm: add ACPI fields to global data

[Heinrich Schuchardt]

On 12/16/23 19:46, Simon Glass wrote:
> Hi Heinrich,
> 
> On Fri, 15 Dec 2023 at 06:32, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
>>
>> Add fields for the location of ACPI tables to the global data.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>> v2:
>>          new patch
>> ---
>>   arch/arm/include/asm/global_data.h | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
> These need to be #ifdefed as they affect global_data size,
> particularly in SPL. In fact, we have a problem there.

Why would it be problematic to have more unused fields in global data?

Best regards

Heinrich

> 
>>
>> diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h
>> index 75bd9d56f8..9505399bb1 100644
>> --- a/arch/arm/include/asm/global_data.h
>> +++ b/arch/arm/include/asm/global_data.h
>> @@ -19,6 +19,10 @@ struct arch_global_data {
>>   #if defined(CONFIG_FSL_ESDHC) || defined(CONFIG_FSL_ESDHC_IMX)
>>          u32 sdhc_clk;
>>   #endif
>> +       ulong table_start;              /* Start address of ACPI tables */
>> +       ulong table_end;                /* End address of ACPI tables */
>> +       ulong table_start_high;         /* Start address of high ACPI tables */
>> +       ulong table_end_high;           /* End address of high ACPI tables */
>>
>>   #if defined(CONFIG_FSL_ESDHC)
>>          u32 sdhc_per_clk;
>> --
>> 2.40.1
>>
> 
> Regards,
> Simon