[PATCH 10/10] Makefile: Use the fdtgrep -u flag

Tom Rini trini at konsulko.com
Sun Dec 17 19:41:10 CET 2023


On Sun, Dec 17, 2023 at 09:36:23AM -0700, Simon Glass wrote:
> Use this flag so that the bootph binding is obeyed correctly.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Fixes: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/12

First of all, yay, this will I believe unblock upstreaming of these
properties.

> ---
> 
>  scripts/Makefile.lib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 8dc6ec82cd56..21b1f7daa72c 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -631,7 +631,7 @@ fdtgrep_props := -b bootph-all -b bootph-pre-ram $(migrate_spl)
>  endif
>  endif
>  quiet_cmd_fdtgrep = FDTGREP $@
> -      cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
> +      cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -u -RT $< \
>  		-n /chosen -n /config -O dtb | \
>  	$(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
>  		-P bootph-all -P bootph-pre-ram -P bootph-pre-sram \

Maybe we need to expand / add some comment here? In practice right now
I don't think we have an issue in that say "keep-power-in-suspend" is
already not being included in these special subset trees, but we want to
I think at least make it clear for future users what unexpected things
might happen.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231217/3a1875ee/attachment.sig>


More information about the U-Boot mailing list