[PATCH v3 1/7] rpi5: add initial memory map for bcm2712

[Stefan Wahren]

Hi Ivan,

Am 18.12.23 um 22:03 schrieb Ivan T. Ivanov:
> From: Dmitry Malkin <dmitry at bedrocksystems.com>
>
> includes:
> * 1GB of RAM (from 4GB or 8GB total)
> * VPU memory interface
> * AXI ranges (main peripherals)
my experience with U-Boot is little, but i do my best to give you some
feedback.
>
> Signed-off-by: Dmitry Malkin <dmitry at bedrocksystems.com>
> Signed-off-by: Ivan T. Ivanov <iivanov at suse.de>
> ---
>   arch/arm/mach-bcm283x/init.c | 38 +++++++++++++++++++++++++++++++++++-
>   1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm283x/init.c b/arch/arm/mach-bcm283x/init.c
> index 7265faf6ce..af23b9711a 100644
> --- a/arch/arm/mach-bcm283x/init.c
> +++ b/arch/arm/mach-bcm283x/init.c
> @@ -19,7 +19,7 @@
>   #ifdef CONFIG_ARM64
>   #include <asm/armv8/mmu.h>
>
> -#define MEM_MAP_MAX_ENTRIES (4)
> +#define MEM_MAP_MAX_ENTRIES (5)
>
>   static struct mm_region bcm283x_mem_map[MEM_MAP_MAX_ENTRIES] = {
>   	{
> @@ -68,6 +68,41 @@ static struct mm_region bcm2711_mem_map[MEM_MAP_MAX_ENTRIES] = {
>   	}
>   };
>
> +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = {
> +	{
in comparison to mach-imx/imx9/soc.c most of the memory maps doesn't
have a describing comment.
> +		.virt = 0x00000000UL,
> +		.phys = 0x00000000UL,
> +		.size = 0x3f800000UL,
> +		.attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
> +			 PTE_BLOCK_INNER_SHARE
> +	}, {
> +		.virt = 0x3f800000UL,
> +		.phys = 0x3f800000UL,
> +		.size = 0x00800000UL,
> +		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> +			 PTE_BLOCK_NON_SHARE |
> +			 PTE_BLOCK_PXN | PTE_BLOCK_UXN
> +	}, {
> +		/* Beginning of AXI bus where uSD controller lives */
> +		.virt = 0x1000000000UL,
> +		.phys = 0x1000000000UL,
> +		.size = 0x0002000000UL,
> +		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> +			 PTE_BLOCK_NON_SHARE |
> +			 PTE_BLOCK_PXN | PTE_BLOCK_UXN
> +	}, {
> +		.virt = 0x107c000000UL,
> +		.phys = 0x107c000000UL,
> +		.size = 0x0004000000UL,
> +		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> +			 PTE_BLOCK_NON_SHARE |
> +			 PTE_BLOCK_PXN | PTE_BLOCK_UXN
> +	}, {
> +		/* List terminator */
> +		0,
> +	}
> +};
> +
>   struct mm_region *mem_map = bcm283x_mem_map;
>
>   /*
> @@ -78,6 +113,7 @@ static const struct udevice_id board_ids[] = {
>   	{ .compatible = "brcm,bcm2837", .data = (ulong)&bcm283x_mem_map},
>   	{ .compatible = "brcm,bcm2838", .data = (ulong)&bcm2711_mem_map},
>   	{ .compatible = "brcm,bcm2711", .data = (ulong)&bcm2711_mem_map},
> +	{ .compatible = "brcm,bcm2712", .data = (ulong)&bcm2712_mem_map},
>   	{ },
>   };
>
Looking at the complete file, i saw the function print_cpuinfo().
Personally i think it's wrong to print BCM283x in case of a RPI 4 or 5.