[RFC PATCH 11/16] arm: dts: k3-am654-base-board: Add ICSSG2 Ethernet support

[Anwar, Md Danish]

On 12/20/2023 3:38 PM, Roger Quadros wrote:
> 
> 
> On 19/12/2023 12:34, MD Danish Anwar wrote:
>> ICSSG2 provides dual Gigabit Ethernet support.
>> Add ICSSG2 ethernet node to an overlay k3-am654-icssg2.dtso
>>
>> Signed-off-by: MD Danish Anwar <danishanwar at ti.com>
>> ---
>>  arch/arm/dts/Makefile             |   3 +-
>>  arch/arm/dts/k3-am654-icssg2.dtso | 145 ++++++++++++++++++++++++++++++
>>  2 files changed, 147 insertions(+), 1 deletion(-)
>>  create mode 100644 arch/arm/dts/k3-am654-icssg2.dtso
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index e9e58c5478..2bc53fba89 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -1396,7 +1396,8 @@ dtb-$(CONFIG_SOC_K3_AM654) += \
>>  	k3-am6548-iot2050-advanced-pg2.dtb \
>>  	k3-am6548-iot2050-advanced-m2.dtb \
>>  	k3-am6548-iot2050-advanced-m2-bkey-usb3-overlay.dtbo \
>> -	k3-am6548-iot2050-advanced-m2-bkey-ekey-pcie-overlay.dtbo
>> +	k3-am6548-iot2050-advanced-m2-bkey-ekey-pcie-overlay.dtbo \
>> +	k3-am654-icssg2.dtbo
>>  dtb-$(CONFIG_SOC_K3_J721E) += k3-j721e-common-proc-board.dtb \
>>  			      k3-j721e-r5-common-proc-board.dtb \
>>  			      k3-j7200-common-proc-board.dtb \
>> diff --git a/arch/arm/dts/k3-am654-icssg2.dtso b/arch/arm/dts/k3-am654-icssg2.dtso
>> new file mode 100644
>> index 0000000000..faefa2febc
>> --- /dev/null
>> +++ b/arch/arm/dts/k3-am654-icssg2.dtso
> 
> Why is this an overlay file? Isn't ICSSG2 part of base board?
> 

It was decided during linux upstreaming [1] of this patch that ICSSG2
node should be added in overlay (suggested by 'Andrew Davis
<afd at ti.com>'). As this node is in overlay in upstream linux, I kept it
in overlay in upstream uboot as well.

[1] https://lore.kernel.org/all/f1fe8dab-350d-002e-c922-58e5912bd76f@ti.com/

>> @@ -0,0 +1,145 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/**
>> + * DT overlay for enabling ICSSG2 on AM654 EVM
>> + *
>> + * Copyright (C) 2018-2023 Texas Instruments Incorporated - https://www.ti.com/
>> + */
>> +

[ ... ]

-- 
Thanks and Regards,
Md Danish Anwar