[PATCH v2] test/py: i2c: Add tests for i2c command

Tom Rini trini at konsulko.com
Wed Dec 20 20:12:04 CET 2023


On Wed, Dec 20, 2023 at 05:45:24PM +0100, Michal Simek wrote:
> 
> 
> On 12/20/23 16:46, Tom Rini wrote:
> > On Tue, Nov 21, 2023 at 05:28:43PM +0530, Love Kumar wrote:
> > 
> > > Add below test cases for i2c commands:
> > > i2c_bus - To show i2c bus info,
> > > i2c_dev - To set or show the current bus,
> > > i2c_probe - To probe the i2c device,
> > > i2c_eeprom - To test i2c eeprom device,
> > > i2c_probe_all_buses - To list down all the buses and probes it
> > > 
> > > Signed-off-by: Love Kumar <love.kumar at amd.com>
> > > Reviewed-by: Tom Rini <trini at konsulko.com>
> > > ---
> > > Changes in v2:
> > > - Take the configured eeprom value from env to read back and compare
> > > ---
> > >   test/py/tests/test_i2c.py | 108 ++++++++++++++++++++++++++++++++++++++
> > >   1 file changed, 108 insertions(+)
> > >   create mode 100644 test/py/tests/test_i2c.py
> > 
> > So this leads to failures in CI on other platforms.  Please put this and
> > the other tests through CI:
> > https://docs.u-boot.org/en/latest/develop/ci_testing.html
> 
> Can you give me link to that gitlab build to see it?
> I can push it via my tree but it will be just resource wasting to see errors
> which you have seen already.

The first failure is
https://source.denx.de/u-boot/u-boot/-/jobs/758375#L268 but I suspect
that like the mii or mdio (I forget which now) test, they end up needing
to be opt-in, but should also have their comments expanded to make sure
it's clear what expected values to configure the test are.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231220/0fdd9290/attachment.sig>


More information about the U-Boot mailing list