[PATCH 0/2 v2] Provide a fallback to smbios tables

Ilias Apalodimas ilias.apalodimas at linaro.org
Thu Dec 21 10:18:48 CET 2023


On Thu, 21 Dec 2023 at 11:18, <neil.armstrong at linaro.org> wrote:
>
> On 27/11/2023 18:10, Ilias Apalodimas wrote:
> > Hi,
> > Tom asked me to clean up and resend [0].
> > I've made some adjustments -- The DT nodes are tokenized and a single
> > string is used. The DT node 'model' is used to fill the SMBIOS
> > 'Product Name' and 'compatible' is used for 'Manufacturer'.
> >
> > The reason is explained in patch#2 but the tl;dr is that model doesn't
> > always include the manufacturer despite the suggestions of the DT spec.
> >
> > [0] https://lore.kernel.org/u-boot/20220906134426.53748-1-ilias.apalodimas@linaro.org/
> >
> > Ilias Apalodimas (2):
> >    smbios: Simplify reporting of unknown values
> >    smbios: Fallback to the default DT if sysinfo nodes are missing
> >
> >   lib/smbios.c | 109 +++++++++++++++++++++++++++++++++++++++++++--------
> >   1 file changed, 92 insertions(+), 17 deletions(-)
> >
> > --
> > 2.40.1
> >
>
> I did it already offline, but:
>
> Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
> Tested-by: Neil Armstrong <neil.armstrong at linaro.org> # on libretech-cc
>
> Thanks,
> Neil

Thanks for testing Neil!
/Ilias


More information about the U-Boot mailing list