[PATCH v3 06/14] bloblist: Drop spare value from bloblist record

Ilias Apalodimas ilias.apalodimas at linaro.org
Wed Dec 27 10:42:40 CET 2023


Hi Raymond,

On Mon, 18 Dec 2023 at 20:20, Raymond Mao <raymond.mao at linaro.org> wrote:
>
> From: Simon Glass <sjg at chromium.org>
>
> Drop spare value from bloblist record header.
>
> For now it is still present in the header, with an underscore, so that
> tests continue to pass.

I am not sure I understand the commit message. Doesn't the spec define
this as 'reserved' now?
On top of that, it's a better idea to follow the spec naming. It's
easier to map the spec -> code for new readers. So I would rename

tag -> tag_id
size -> data_size and
flags -> reserved.

Can we at least do the flags -> reserved in this patch?

[...]

Thanks
/Ilias


More information about the U-Boot mailing list