[PATCH v3 11/14] bloblist: Adjust the bloblist header

[Ilias Apalodimas]

On Wed, 27 Dec 2023 at 17:09, Raymond Mao <raymond.mao at linaro.org> wrote:
>
> Hi Ilias,
>
> On Wed, 27 Dec 2023 at 09:58, Ilias Apalodimas <ilias.apalodimas at linaro.org> wrote:
>>
>> On Wed, 27 Dec 2023 at 16:50, Raymond Mao <raymond.mao at linaro.org> wrote:
>> >
>> > Hi Ilias,
>> >
>> > On Wed, 27 Dec 2023 at 05:17, Ilias Apalodimas <ilias.apalodimas at linaro.org> wrote:
>> >>
>> >>
>> >> [...]
>> >>
>> >> > - * @chksum: checksum for the entire bloblist allocated area. Since any of the
>> >> > - *   blobs can be altered after being created, this checksum is only valid
>> >> > - *   when the bloblist is finalised before jumping to the next stage of boot.
>> >> > - *   This is the value needed to make all checksummed bytes sum to 0
>> >> >   */
>> >> >  struct bloblist_hdr {
>> >> >       u32 magic;
>> >> > -     u32 version;
>> >> > -     u32 hdr_size;
>> >> > -     u32 flags;
>> >> > -
>> >> > -     u32 size;
>> >> > +     u8 chksum;
>> >> > +     u8 version;
>> >> > +     u8 hdr_size;
>> >> > +     u8 align_log2;
>> >> >       u32 alloced;
>> >> > +     u32 size;
>> >> > +     u32 flags;
>> >> >       u32 spare;
>> >> > -     u32 chksum;
>> >> >  };
>> >> >
>> >>
>> >> Aren't fields still missing from the current version?
>> >> e.g max_size and reserved?
>> >>
>> > They are all in. Please see:
>> > [PATCH v3 14/14] bloblist: Align bloblist used_size and total_size to spec
>>
>> Ok. But why aren't we squashing this to #14 then?
>>
> I can squash other changes with #14 except the ones for `align_log2`.
> And `align_log2` with patch #12 due to the dependency.

I think that's better.

Thanks
/Ilias
>
> Regards,
> Raymond
>
>>
>> Thanks
>> /Ilias
>> >
>> > [...]
>> >
>> > Regards,
>> > Raymond