[PATCH v4 06/12] bloblist: Drop spare value from bloblist record

[Ilias Apalodimas]

Hi Raymond,

On Wed, 27 Dec 2023 at 23:08, Raymond Mao <raymond.mao at linaro.org> wrote:
>
> From: Simon Glass <sjg at chromium.org>
>
> Drop spare value from bloblist record header.
>
> For now it is still present in the header, with an underscore, so that
> tests continue to pass.
>

Looking at it again, this commit makes no sense to me. Why is this
needed in the series? And why can't we just fold it into patch #10?

Thanks
/Ilias
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Co-developed-by: Raymond Mao <raymond.mao at linaro.org>
> Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> ---
> Changes in v3
> - Keep the spare value in the bloblist header to align to FW handoff spec up to commit 3592349.
>
>  common/bloblist.c  | 1 -
>  include/bloblist.h | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/bloblist.c b/common/bloblist.c
> index 168993e0a7..88e2a0f5c0 100644
> --- a/common/bloblist.c
> +++ b/common/bloblist.c
> @@ -165,7 +165,6 @@ static int bloblist_addrec(uint tag, int size, int align_log2,
>         rec->tag = tag;
>         rec->hdr_size = data_start - hdr->alloced;
>         rec->size = size;
> -       rec->spare = 0;
>
>         /* Zero the record data */
>         memset((void *)rec + rec_hdr_size(rec), '\0', rec->size);
> diff --git a/include/bloblist.h b/include/bloblist.h
> index 7eff709ec8..68f97395b7 100644
> --- a/include/bloblist.h
> +++ b/include/bloblist.h
> @@ -205,13 +205,12 @@ struct bloblist_hdr {
>   *     record's data starts at this offset from the start of the record
>   * @size: Size of record in bytes, excluding the header size. This does not
>   *     need to be aligned (e.g. 3 is OK).
> - * @spare: Spare space for other things
>   */
>  struct bloblist_rec {
>         u32 tag;
>         u32 hdr_size;
>         u32 size;
> -       u32 spare;
> +       u32 _spare;
>  };
>
>  /**
> --
> 2.25.1
>