[PATCH 1/9] microblaze: dts: Use the normal build rule

[Simon Glass]

Hi Tom,

On Wed, Dec 27, 2023 at 1:20 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Dec 27, 2023 at 08:23:57AM +0000, Simon Glass wrote:
> > Build devicetree files using the normal SoC-generic rule. For
> > microblaze there is actually only one SoC and one board.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  arch/microblaze/dts/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/microblaze/dts/Makefile b/arch/microblaze/dts/Makefile
> > index 427a8f9aaca..adc76ddf21f 100644
> > --- a/arch/microblaze/dts/Makefile
> > +++ b/arch/microblaze/dts/Makefile
> > @@ -1,6 +1,6 @@
> >  # SPDX-License-Identifier: GPL-2.0+
> >
> > -dtb-y += $(shell echo $(CONFIG_DEFAULT_DEVICE_TREE)).dtb
> > +dtb-$(CONFIG_MICROBLAZE) += microblaze-generic.dtb
> >
> >  include $(srctree)/scripts/Makefile.dts
>
> This (and nios2 and perhaps a few other arches) show that it would be
> easier to just drop the dts- line as it adds nothing over what
> scripts/Makefile.dts gives us.

For consistency I like to see a rule for each .dtb in the directory.

> I wonder how this will interact with
> OF_UPSTREAM and how it compares with arch/microblaze/boot/dts/system.dts
> in the linux kernel.

I don't see any interaction. Perhaps the maintainer can move this to
OF_UPSTREAM?

Regards,
Simon