[PATCH 12/26] arm: dts: k3-am654: add needed regs to udmap nodes

Bryan Brattlof bb at ti.com
Thu Dec 28 18:18:49 CET 2023


On December 27, 2023 thus sayeth Nishanth Menon:
> On 11:43-20231221, Bryan Brattlof wrote:
> > Ethernet is one of a few IPs in U-Boot that depend on DMA to operate.
> > However there are a few missing registers ranges in the udmap nodes
> > need to properly setup DMA for the am65x.
> > 
> > A fix has been added to the Linux kernel[0] to add these ranges however
> > they have not made it to a Linux tag. To keep DMA operational until the
> > next DT sync from Linux, add these ranges to the *-u-boot.dtsi with a
> > note for our future selves.
> > 
> > [0] https://lore.kernel.org/r/20231213135138.929517-2-vigneshr@ti.com
> > Signed-off-by: Bryan Brattlof <bb at ti.com>
> > ---
> >  arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 32 ++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> > 
> > diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi b/arch/arm/dts/k3-am654-base-board-u-boot.dtsi
> > index 9cd8c353c515b..645241da322a5 100644
> > --- a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi
> > +++ b/arch/arm/dts/k3-am654-base-board-u-boot.dtsi
> > @@ -260,3 +260,35 @@
> >  &mcu_r5fss0 {
> >  	ti,cluster-mode = <0>;
> >  };
> > +
> > +/* The DMA driver requires a few extra register ranges
> > + * which are missing for the am65x. A patch has been
> > + * sent and will be synced after the v6.8-rc1 linux
> > + * tag is published
> > + */
> 
> Please fix multi-line comment style:
> /*
>  * blah blah
>  */
> instead of
> /* blah blah
>  * more stuff
>  */

Ah yeah I can get all of the comments fixed up.

~Bryan

> > +&main_udmap {
> > +	reg = <0x0 0x31150000 0x0 0x100>,
> > +	      <0x0 0x34000000 0x0 0x100000>,
> > +	      <0x0 0x35000000 0x0 0x100000>,
> > +	      <0x0 0x30b00000 0x0 0x10000>,
> > +	      <0x0 0x30c00000 0x0 0x10000>,
> > +	      <0x0 0x30d00000 0x0 0x8000>;
> > +	reg-names = "gcfg", "rchanrt", "tchanrt",
> > +		    "tchan", "rchan", "rflow";
> > +};
> > +
> > +/* The DMA driver requires a few extra register ranges
> > + * which are missing for the am65x. A patch has been
> > + * sent and will be synced after the v6.8-rc1 linux
> > + * tag is published
> > + */
> 
> and here.
> 
> > +&mcu_udmap {
> > +	reg = <0x0 0x285c0000 0x0 0x100>,
> > +	      <0x0 0x2a800000 0x0 0x40000>,
> > +	      <0x0 0x2aa00000 0x0 0x40000>,
> > +	      <0x0 0x284a0000 0x0 0x4000>,
> > +	      <0x0 0x284c0000 0x0 0x4000>,
> > +	      <0x0 0x28400000 0x0 0x2000>;
> > +	reg-names = "gcfg", "rchanrt", "tchanrt",
> > +		    "tchan", "rchan", "rflow";
> > +};
> > -- 
> > 2.43.0
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


More information about the U-Boot mailing list