[PATCH 01/11] imx: implement get_effective_memsize
peng.fan at oss.nxp.com
Wed Feb 1 01:15:57 CET 2023
On 1/31/2023 7:10 PM, Stefano Babic wrote:
> On 31.01.23 12:02, Fabio Estevam wrote:
>> Hi Peng,
>> On Mon, Nov 7, 2022 at 4:13 AM Peng Fan (OSS) <peng.fan at oss.nxp.com>
>>> From: Peng Fan <peng.fan at nxp.com>
>>> To i.MX6/7 which has 2GB memory, the upper 4KB cut off, will cause the
>>> top 1MB not mapped as normal memory, because ARMV7-A use section
>>> mapping. So implement i.MX6/7 specific get_effective_memsize to fix the
>>> Fixes: 777aaaa706bc("common/memsize.c: Fix get_effective_memsize() to
>>> check for overflow")
>> This commit has been reverted in master for non-Power PC platforms:
>> commit d1f4b090dd17ee11373859f2c91af94bf254af7a
>> Author: Pali Rohár <pali at kernel.org>
>> Date: Sat Jan 7 22:55:26 2023 +0100
>> common/memsize.c: Check for overflow in get_effective_memsize()
>> only for mpc85xx
>> This reverts commit 777aaaa706bc ("common/memsize.c: Fix
>> get_effective_memsize() to check for overflow") for non-mpc85xx
>> The changes to this generic function, which is intended to help with
>> 32bit platforms with large amounts of memory has unintended side
>> (which in turn lead to boot failures) on other platforms which were
>> previously functional.
>> For now do overflow check only for powerpc mpc85xx platform. It
>> is needed
>> to prevent crashing of P1/P2 boards with 4GB DDR module in 32-bit
>> Fixes: 777aaaa706bc ("common/memsize.c: Fix
>> get_effective_memsize() to check for overflow")
>> Signed-off-by: Pali Rohár <pali at kernel.org>
>> Can this patch be discarded then?
>> I just noticed that Stefano applied it to u-boot-imx master-next branch.
> Yes, it is in test - I could let it out for the moment, waiting for
> Peng's answer.
Yes, this patch could dropped, since the common code already has fix.
More information about the U-Boot