[PATCH v2 07/12] reset: uniphier: Add USB glue reset support

[Marek Vasut]

On 2/2/23 06:38, Kunihiko Hayashi wrote:
> Hi Marek,

Hello Hayashi-san,

> On 2023/02/02 6:51, Marek Vasut wrote:
>> On 2/1/23 02:13, Kunihiko Hayashi wrote:
>>> Add reset control support in USB glue logic. This needs to control
>>> the external clocks and resets for the logic before accessing the
>>> glue logic.
>>>
>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
>>
>> With the very little knowledge I have of this platform:
>> Reviewed-by: Marek Vasut <marex at denx.de>
> 
> I see. I should make some explanation.
> 
> The dm tree for usb is the following.
> 
>    glue
>      +-- controller       (need controller-reset)
>      +-- controller-reset (need syscon-reset)
>      +-- phy
> 
> The controller needs to deassert "controller-reset" in the glue.
> The glue needs to deassert "syscon-reset".
> 
> The glue node itself doesn't have "resets" property, so
> the controller-reset controls "syscon-reset" instead.
> 
> This patch adds the reset control for "controller-reset".

Thank you for the clarification.

I think there are a few things which still require V3, but it is 
starting to look very good.