[PATCH 1/2] env: Complete generic support for writable list

Jan Kiszka jan.kiszka at siemens.com
Fri Feb 3 13:22:51 CET 2023

From: Jan Kiszka <jan.kiszka at siemens.com>

This completes what 890feecaab72 started by selecting ENV_APPEND and
loading the default env before any other sources. This ensures that load
operations pick up all non-writable vars from the default env and only
permitted parts from other locations according to the regular

With this change, boards only need to define the list of writable
variables but no longer have to provide a custom env_get_location

CC: Joe Hershberger <joe.hershberger at ni.com>
CC: Marek Vasut <marex at denx.de>
CC: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss at weidmueller.com>
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Reviewed-by: Marek Vasut <marex at denx.de>
 env/Kconfig | 1 +
 env/env.c   | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/env/Kconfig b/env/Kconfig
index c409ea71fe5..6e24eee55f2 100644
--- a/env/Kconfig
+++ b/env/Kconfig
@@ -733,6 +733,7 @@ config ENV_APPEND
 	bool "Permit write access only to listed variables"
+	select ENV_APPEND
 	  If defined, only environment variables which explicitly set the 'w'
 	  writeable flag can be written and modified at runtime. No variables
diff --git a/env/env.c b/env/env.c
index 06078c7f374..45e638fcd1f 100644
--- a/env/env.c
+++ b/env/env.c
@@ -195,6 +195,14 @@ int env_load(void)
 	int best_prio = -1;
 	int prio;
+		/*
+		 * When using a list of writeable variables, the baseline comes
+		 * from the built-in default env. So load this first.
+		 */
+		env_set_default(NULL, 0);
+	}
 	for (prio = 0; (drv = env_driver_lookup(ENVOP_LOAD, prio)); prio++) {
 		int ret;

More information about the U-Boot mailing list