[PATCH 2/4] usb: xhci-mtk: modify the SOF/ITP interval for mt8195

[Marek Vasut]

On 2/10/23 09:33, Chunfeng Yun wrote:
[...]
> @@ -50,6 +50,27 @@
>   #define IPPC_U3_CTRL(p)	(IPPC_U3_CTRL_0P + ((p) * 0x08))
>   #define IPPC_U2_CTRL(p)	(IPPC_U2_CTRL_0P + ((p) * 0x08))
>   
> +/* xHCI CSR */
> +#define LS_EOF_CFG		0x930
> +#define LSEOF_OFFSET		0x89
> +
> +#define FS_EOF_CFG		0x934
> +#define FSEOF_OFFSET		0x2e
> +
> +#define SS_GEN1_EOF_CFG		0x93c
> +#define SSG1EOF_OFFSET		0x78
> +
> +#define HFCNTR_CFG		0x944
> +#define ITP_DELTA_CLK		(0xa << 1)
> +#define ITP_DELTA_CLK_MASK	GENMASK(5, 1)
> +#define FRMCNT_LEV1_RANG	(0x12b << 8)

Look at FIELD_PREP() macro, that should let you avoid the (0x12b << 8) .

> +#define FRMCNT_LEV1_RANG_MASK	GENMASK(19, 8)
> +
> +#define SS_GEN2_EOF_CFG		0x990
> +#define SSG2EOF_OFFSET		0x3c
> +
> +#define XSEOF_OFFSET_MASK	GENMASK(11, 0)

[...]

> @@ -308,6 +354,7 @@ static int xhci_mtk_remove(struct udevice *dev)
>   
>   static const struct udevice_id xhci_mtk_ids[] = {
>   	{ .compatible = "mediatek,mtk-xhci" },
> +	{ .compatible = "mediatek,mt8195-xhci" },

Is the extra compatible string really needed, can't the driver match on 
the generic one ?