[PATCH v3 02/14] net: Pull board_interface_eth_init() into common code

Simon Glass sjg at chromium.org
Mon Feb 13 00:13:56 CET 2023


Hi,

On Sat, 11 Feb 2023 at 14:48, Marek Vasut <marex at denx.de> wrote:
>
> Move the board_interface_eth_init() into common ethernet uclass code,
> since this function could be shared by multiple drivers.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: "Ariel D'Alessandro" <ariel.dalessandro at collabora.com>
> Cc: "NXP i.MX U-Boot Team" <uboot-imx at nxp.com>
> Cc: Andrey Zhizhikin <andrey.zhizhikin at leica-geosystems.com>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Lukasz Majewski <lukma at denx.de>
> Cc: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Michael Trimarchi <michael at amarulasolutions.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> Cc: Sean Anderson <seanga2 at gmail.com>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Tim Harvey <tharvey at gateworks.com>
> Cc: Tommaso Merciai <tommaso.merciai at amarulasolutions.com>
> Cc: u-boot at lists.denx.de
> ---
> V3: New patch
> ---
>  drivers/net/dwc_eth_qos.c | 7 -------
>  net/eth-uclass.c          | 7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

Related, we do have a way of adding code to run when a device is
probed (events). Should we look at using that? Is it better or worse
than weak functions?

Regards,
Simon


More information about the U-Boot mailing list