[PATCH V2] arm64: imx: Add support for imx8mp-beacon-kit

[Tom Rini]

On Sun, Feb 12, 2023 at 05:57:35PM -0600, Adam Ford wrote:

> Beacon Embedded has an i.MX8M Plus development kit which consists
> of a SOM + baseboard.  The SOM includes Bluetooth, WiFi, QSPI, eMMC,
> and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual
> Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet
> PHY.  The device trees are already queued for inclusion in Linux 6.3.
> 
> Signed-off-by: Adam Ford <aford173 at gmail.com>
[snip]
> diff --git a/board/beacon/imx8mp/imx8mp_beacon.env b/board/beacon/imx8mp/imx8mp_beacon.env
> new file mode 100644
> index 0000000000..ba9f1e462f
> --- /dev/null
> +++ b/board/beacon/imx8mp/imx8mp_beacon.env
> @@ -0,0 +1,29 @@
> +arch=arm
> +baudrate=115200
> +board=imx8mp
> +board_name=imx8mp

You don't need to specify the variables that will be set via
include/env_default.h (and if you see an example that is, whoops), just
what you normally would have put in CFG_EXTRA_ENV_SETTINGS. I see a few
more in here as well that should be pulled.

> diff --git a/doc/board/beacon/beacon-imx8mp.rst b/doc/board/beacon/beacon-imx8mp.rst
> new file mode 100644
> index 0000000000..375931c07d
> --- /dev/null
> +++ b/doc/board/beacon/beacon-imx8mp.rst
> @@ -0,0 +1,52 @@

I _think_ this is fine itself, but please run 'make htmldocs' (see
doc/build/documentation.rst for instructions) as I'm pretty sure you
didn't since this is a new directory and so index files need to be
updated too.

[snip]
> +++ b/include/configs/imx8mp_beacon.h
> @@ -0,0 +1,31 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2022 Logic PD, Inc dba Beacon EmbeddedWorks
> + */
> +
> +#ifndef __IMX8MP_BEACON_H
> +#define __IMX8MP_BEACON_H
> +
> +#include <linux/sizes.h>
> +#include <linux/stringify.h>
> +#include <asm/arch/imx-regs.h>

While I'm seeing it again, do we _really_ need these includes here?

> +#define CFG_SYS_UBOOT_BASE	(QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512)
> +
> +#if defined(CONFIG_CMD_NET)
> +#define PHY_ANEG_TIMEOUT 20000
> +#endif
> +
> +/* Link Definitions */
> +
> +#define CFG_SYS_INIT_RAM_ADDR	0x40000000
> +#define CFG_SYS_INIT_RAM_SIZE	0x80000
> +
> +/* Totally 6GB DDR */
> +#define CFG_SYS_SDRAM_BASE		0x40000000
> +#define PHYS_SDRAM			0x40000000
> +#define PHYS_SDRAM_SIZE			0xC0000000	/* 3 GB */
> +#define PHYS_SDRAM_2			0x100000000
> +#define PHYS_SDRAM_2_SIZE		0xC0000000	/* 3 GB */

And are all of these still, strictly, required? I can accept that they
are but it's good to confirm, as part of the CONFIG migration work I
saw a lot of seemingly not needed anymore defines in config header
files, and we're getting closer now to being able to make the file
optional.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230213/b45a707c/attachment.sig>