[PATCH v3 1/9] video console: unite normal and rotated files

Simon Glass sjg at chromium.org
Thu Feb 16 00:49:49 CET 2023


Hi Dzmitry,

On Wed, 15 Feb 2023 at 04:43, Dzmitry Sankouski <dsankouski at gmail.com> wrote:
>
> Unite console_normal.c and console_rotate.c files.
> Those files have similar logic, and common logic
> may be extracted after putting code in single file.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski at gmail.com>
> ---
> Changes for v2: none
> Changes for v3: none
>
>  drivers/video/Kconfig                         |   8 +-
>  drivers/video/Makefile                        |   3 +-
>  drivers/video/console_normal.c                | 178 ------------------
>  .../{console_rotate.c => console_simple.c}    | 166 ++++++++++++++++
>  4 files changed, 171 insertions(+), 184 deletions(-)
>  delete mode 100644 drivers/video/console_normal.c
>  rename drivers/video/{console_rotate.c => console_simple.c} (75%)

I would prefer to keep these separate, rather than adding an #ifdef.
Could you add an internal header file like
drivers/video/video_internal.h to export the shared functions?

Regards,
Simon


More information about the U-Boot mailing list