[PATCH] lmb: Bump CONFIG_LMB_MAX_REGIONS

[Michal Suchánek]

Hello,

On Sun, Feb 12, 2023 at 06:45:36PM -0500, Tom Rini wrote:
> On Wed, Feb 08, 2023 at 02:50:16PM -0500, Tom Rini wrote:
> > On Wed, Feb 08, 2023 at 08:11:34PM +0100, Michal Suchánek wrote:
> > > Hello,
> > > 
> > > On Wed, Feb 08, 2023 at 01:25:50PM -0500, Tom Rini wrote:
> > > > On Wed, Feb 08, 2023 at 07:24:25PM +0100, Francesco Dolcini wrote:
> > > > > Hello,
> > > > > 
> > > > > On Fri, Jan 27, 2023 at 08:54:55AM -0500, Tom Rini wrote:
> > > > > > On Fri, Jan 27, 2023 at 02:00:12PM +0100, Michal Suchanek wrote:
> > > > > > > It is reported that in some configurations it is not possible to boot
> > > > > > > because u-boot runs out of lmbs.
> > > > > > > 
> > > > > > > commit 06d514d77c ("lmb: consider EFI memory map") increases lmb usage,
> > > > > > > hence is likely the cause of the lmb overflow.
> > > > > > > 
> > > > > > > Fixes: 06d514d77c ("lmb: consider EFI memory map")
> > > > > > > Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1207562
> > > > > > > Signed-off-by: Michal Suchanek <msuchanek at suse.de>
> > > > > 
> > > > > Reviewed-by: Francesco Dolcini <francesco.dolcini at toradex.com>
> > > > > 
> > > > > > I plan to pick up
> > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230125230823.1567778-1-trini@konsulko.com/
> > > > > > as the alternative fix for this issue and would suggest that any distro
> > > > > > hitting the problem on v2023.01 apply the above instead of increasing
> > > > > > the limit.
> > > > > 
> > > > > Tom, my understanding is that you plan to merge this or an equivalent
> > > > > change, correct? Otherwise I would need to send some more patches to
> > > > > update a few board defconfig that are affected by this specific issue.
> > > > 
> > > > Yes, I was hoping to push the equivalent of this patch a few hours ago,
> > > > along with the revert. Then I noticed the test in test/lib/lmb.c doesn't
> > > > scale past 8, and I just now figured out what that should look like
> > > > instead, I believe.
> > > 
> > > reportedly neither fixes the problem in all cases, and raising
> > > CONFIG_LMB_RESERVED_REGIONS is required.
> > > 
> > > Looks like the mechanism to add regions above the default number does
> > > not work as intended.
> > > 
> > > The test is to boot rPi 4 from USB directly with recent firmware.
> > 
> > Well, given 0089affee275 ("configs: stm32mp15: increase the number of
> > reserved memory region in lmb") I guess this has been run in to before,
> > but not resolved more generically.
> 
> I wonder if
> https://patchwork.ozlabs.org/project/uboot/patch/20230212150706.2967007-2-sjoerd@collabora.com/
> is what will finish dealing with these issues, even the ones that had
> perhaps shown up before and been addressed in the commit I mentioned
> above?

Looks like this together with raising the maximum number of regions
works, that is v2023.04-rc2 should be fixed.

Thanks

Michal