[PATCH 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

[Michal Simek]

On 2/21/23 08:03, Ashok Reddy Soma wrote:
> From: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> 
> Add missing prototype to fix the sparse warning, warning: no
> previous prototype for 'board_boot_order' [-Wmissing-prototypes].
> 
> Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> ---
> 
>   arch/arm/mach-zynqmp/include/mach/sys_proto.h | 1 +
>   common/spl/spl.c                              | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-zynqmp/include/mach/sys_proto.h b/arch/arm/mach-zynqmp/include/mach/sys_proto.h
> index c6733ed1bb..0f648c47a3 100644
> --- a/arch/arm/mach-zynqmp/include/mach/sys_proto.h
> +++ b/arch/arm/mach-zynqmp/include/mach/sys_proto.h
> @@ -51,6 +51,7 @@ unsigned int zynqmp_get_silicon_version(void);
>   int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value);
>   int zynqmp_mmio_read(const u32 address, u32 *value);
>   
> +void board_boot_order(u32 *spl_boot_list);
>   void initialize_tcm(bool mode);
>   void mem_map_fill(void);
>   #if defined(CONFIG_SYS_MEM_RSVD_FOR_MMU) || defined(CONFIG_DEFINE_TCM_OCM_MMAP)
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index a630e79866..6e5f326481 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -20,6 +20,7 @@
>   #include <serial.h>
>   #include <spl.h>
>   #include <system-constants.h>
> +#include <asm/arch/sys_proto.h>

This doesn't look right because then you expect all spl platforms will have this 
header which is not the case.

It should go to include/spl.h

>   #include <asm/global_data.h>
>   #include <asm-generic/gpio.h>
>   #include <asm/u-boot.h>

M