[PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

Simon Glass sjg at chromium.org
Tue Feb 21 20:35:41 CET 2023


Hi Tom,

On Tue, 14 Feb 2023 at 09:31, Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote:
> > This converts 1 usage of this option to the non-SPL form, since there is
> > no SPL_PHY_CADENCE_SIERRA defined in Kconfig
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> >  drivers/phy/cadence/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile
> > index af63b32d9f5..c247feb8262 100644
> > --- a/drivers/phy/cadence/Makefile
> > +++ b/drivers/phy/cadence/Makefile
> > @@ -1,2 +1,2 @@
> > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA)      += phy-cadence-sierra.o
> > +obj-$(CONFIG_PHY_CADENCE_SIERRA)     += phy-cadence-sierra.o
> >  obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o
>
> This, and then PHY_CADENCE_TORRENT take this the wrong direction, both
> symbols should be false for non-PPL builds.

This one is odd, since the board defines SPL_PHY, presumably for a
reason. It could always undefine that if needed.

I'll add some more notes in v5.

Regards,
SImon


More information about the U-Boot mailing list