[PATCH v2 03/10] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips

[William Zhang]

On 02/11/2023 07:29 AM, Linus Walleij wrote:
> From: Claire Lin <claire.lin at broadcom.com>
> 
> In brcmstb_nand_verify_erased_page(), the ECC chunk pointer calculation
> while correcting erased page bitflips is wrong, fix it.
> 
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
> Signed-off-by: Claire Lin <claire.lin at broadcom.com>
> Reviewed-by: Ray Jui <ray.jui at broadcom.com>
> Signed-off-by: Kamal Dasu <kdasu.kdev at gmail.com>
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> [Ported to U-Boot from the Linux kernel]
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
>   drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index 170aece0aa79..0402cb06a74b 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -1765,6 +1765,7 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd,
>   	int bitflips = 0;
>   	int page = addr >> chip->page_shift;
>   	int ret;
> +	void *ecc_chunk;
>   
>   	if (!buf) {
>   #ifndef __UBOOT__
> @@ -1784,7 +1785,9 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd,
>   		return ret;
>   
>   	for (i = 0; i < chip->ecc.steps; i++, oob += sas) {
> -		ret = nand_check_erased_ecc_chunk(buf, chip->ecc.size,
> +		ecc_chunk = buf + chip->ecc.size * i;
> +		ret = nand_check_erased_ecc_chunk(ecc_chunk,
> +						  chip->ecc.size,
>   						  oob, sas, NULL, 0,
>   						  chip->ecc.strength);
>   		if (ret < 0)
> 

Acked-by: William Zhang <william.zhang at broadcom.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4212 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230221/8366192e/attachment.bin>