[PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

[Martin Rowe]

Pali,

Good news:

A388 Clearfog Base (SD card model):
- MMC from SD card works
- UART works
- SATA with new defconfig works
- SPI (if you select MVEBU_SPL_BOOT_DEVICE_SPI yourself) works
A388 Clearfog Pro (eMMC model):
- MMC from eMMC works, but still requires the dts to be patched for
eMMC (included at bottom)

I tried eMMC both with and without the dts patched, but only the
patched version boots. I am not easily able to test the other boot
methods on the Pro, but they're the same as the Base. Let me know if
you need any extra data/outputs.

Also, the extra/updated comments with these changes are great! Thanks.

Tested-by: Martin Rowe <martin.p.rowe at gmail.com>

Martin

diff --git a/arch/arm/dts/armada-388-clearfog.dts
b/arch/arm/dts/armada-388-clearfog.dts
index e4164f49b2..29a608abcf 100644
--- a/arch/arm/dts/armada-388-clearfog.dts
+++ b/arch/arm/dts/armada-388-clearfog.dts
@@ -101,7 +101,7 @@

                        sdhci at d8000 {
                                bus-width = <4>;
-                               cd-gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
+                               non-removable;
                                no-1-8-v;
                                pinctrl-0 = <&microsom_sdhci_pins
                                             &clearfog_sdhci_cd_pins>;

On Wed, 22 Feb 2023 at 07:58, Pali Rohár <pali at kernel.org> wrote:
>
> On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote:
> > Hi Pali,
> >
> > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár <pali at kernel.org> wrote:
> > >
> > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote:
> > > > Hi Pali,
> > > >
> > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár <pali at kernel.org> wrote:
> > > > >
> > > > > This patch series contains various improvements and fixes for existing
> > > > > logical errors. Boot phase was adjusted to match behavior of Armada 385
> > > > > BootROM by inspecting and disassembling of BootROM binary dump itself.
> > > > > Important information are included in documentation patch for kwboot.
> > > > > Most of the changes are untested, hence this patch series is just RFC.
> > > > > So please test changes before applying, idealy on SPI, SATA and SD/MMC.
> > > > > Nevertheless all patches on github passed CI testing in this PR:
> > > > > https://github.com/u-boot/u-boot/pull/275
> > > ...
> > > > I went to patchwork and downloaded the series.
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-2-pali@kernel.org
> > > >
> > > > When I applied the patches set there were some rejections.
> > > > <BEGIN LOG>
> > > > # patch -p1 < /usr/src/builds-u-boot-marvell/pali_patches/arm-mvebu-Various-fixes.patch
> > > >
> > > ...
> > > FAILED
> > > ...
> > > > <END LOG>
> > > >
> > > > I'm on the latest master branch (just did a git pull today). Could
> > > > some patches be out of order?
> > > >
> > > > Thanks,
> > > > Tony
> > >
> > > Well, that is because DENX mail server is broken and it crashed during
> > > processing antispam filter on my some of my patches. So some patches are
> > > missing in archive and then applying dependent patches failed.
> > >
> > > So ignore patchwork and email patches. Rather fetch changes from the
> > > mentioned github pull request https://github.com/u-boot/u-boot/pull/275
> > >
> > > You can do it via git command (it fetch it to the new mvebu branch):
> > >
> > >   git fetch https://github.com/u-boot/u-boot.git refs/pull/275/merge:mvebu
> >
> > Indeed! That pull request was applied without problem.
> >
> > So I did a general regression test running rebuilt kwboot binary, and
> > rebuilt u-boot images for these 2 Marvell boards:
> >
> > Thecus N2350 (Armada 385)
> > Pogo V4 (Kirkwood 88F6192).
> >
> > So for that part:
> > Tested-by: Tony Dinh <mibodhi at gmail.com>
> >
> > All the best,
> > Tony
>
> Thanks for testing! Anyway do you have some A38x board which can boot
> from SD/MMC, SATA or NAND? This is what is needed to test too. I see
> that Pogo boots from NAND but it does not use SPL.