[PATCH v2 13/13] video: Add a note about the broken implementation

Simon Glass sjg at chromium.org
Wed Feb 22 20:12:57 CET 2023


The cls command is broken. Previous discussion about this was at [1] and
[2]. For now, add a note to the source code.

[1] https://patchwork.ozlabs.org/project/uboot/patch/
       20221022092058.106052-1-heinrich.schuchardt at canonical.com/
[2] https://patchwork.ozlabs.org/project/uboot/patch/
       20230106145243.411626-12-sjg at chromium.org/

Signed-off-by: Simon Glass <sjg at chromium.org>
---

(no changes since v1)

 cmd/cls.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/cmd/cls.c b/cmd/cls.c
index 073ba5a6c86..1125a3f81bb 100644
--- a/cmd/cls.c
+++ b/cmd/cls.c
@@ -17,7 +17,13 @@ static int do_video_clear(struct cmd_tbl *cmdtp, int flag, int argc,
 {
 	__maybe_unused struct udevice *dev;
 
-	/*  Send clear screen and home */
+	/*
+	 * Send clear screen and home
+	 *
+	 * FIXME(Heinrich Schuchardt <xypron.glpk at gmx.de>): This should go
+	 * through an API and only be written to serial terminals, not video
+	 * displays
+	 */
 	printf(CSI "2J" CSI "1;1H");
 	if (IS_ENABLED(CONFIG_VIDEO_ANSI))
 		return 0;
-- 
2.39.2.637.g21b0678d19-goog



More information about the U-Boot mailing list