[PATCH v2 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

Michal Simek michal.simek at amd.com
Fri Feb 24 08:43:05 CET 2023


Hi,


On 2/24/23 05:53, Ashok Reddy Soma wrote:
> From: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> 
> Add missing prototype to fix the sparse warning, warning: no
> previous prototype for 'board_boot_order' [-Wmissing-prototypes].
> 
> Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> ---
> 
> Changes in v2:
>   - Moved function prototype from sys_proto.h to include/spl.h
> 
>   include/spl.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/spl.h b/include/spl.h
> index 827bd25c88..bad12fb01f 100644
> --- a/include/spl.h
> +++ b/include/spl.h
> @@ -884,5 +884,6 @@ void spl_perform_fixups(struct spl_image_info *spl_image);
>    */
>   struct legacy_img_hdr *spl_get_load_buffer(ssize_t offset, size_t size);
>   
> +void board_boot_order(u32 *spl_boot_list);
>   void spl_save_restore_data(void);
>   #endif

The patch is fine but subject not.

Should be something like

spl: Add missing prototype for board_boot_order

M


More information about the U-Boot mailing list