[PATCH 2/2] imx93_evk: enable ADC

Luca Ellero luca.ellero at brickedbrain.com
Fri Feb 24 08:59:29 CET 2023


On 23/02/2023 15:05, Fabio Estevam wrote:
> Hi Luca,
> 
> On Thu, Feb 23, 2023 at 9:52 AM Luca Ellero <l.ellero at asem.it> wrote:
> 
> Please write a commit log.
> 
>> Signed-off-by: Luca Ellero <l.ellero at asem.it>
>> ---
>>   arch/arm/dts/imx93-11x11-evk.dts  | 4 ++++
>>   configs/imx93_11x11_evk_defconfig | 1 +
>>   2 files changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/dts/imx93-11x11-evk.dts b/arch/arm/dts/imx93-11x11-evk.dts
>> index b3a5a3d71e..f7ffe7b3d2 100644
>> --- a/arch/arm/dts/imx93-11x11-evk.dts
>> +++ b/arch/arm/dts/imx93-11x11-evk.dts
>> @@ -525,3 +525,7 @@
>>   &wdog3 {
>>          status = "okay";
>>   };
>> +
>> +&adc1 {
>> +       status = "okay";
>> +};
> 
> The nodes should be kept in alphabetical order.
> 
> Actually, it would be better if you could sync imx93-11x11-evk.dts
> with linux-next, which already contains the adc1 node:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts?h=next-20230223#n37
> 
> We want to keep U-Boot and Linux devicetree in sync as much as possible.
> 
> Thanks

Hi Fabio,
thank you for your reply.
Ok, I will add a comment to the patch and fix DT node.
Should I resend only this patch or both?
Regards

-- 
Luca Ellero

E-mail: luca.ellero at brickedbrain.com
Internet: www.brickedbrain.com




More information about the U-Boot mailing list