[PATCH v2 0/2] rockchip: rk3399: pass platform parameter to TF-A

Quentin Schulz foss+uboot at 0leil.net
Tue Jan 3 15:44:34 CET 2023

From: Quentin Schulz <quentin.schulz at theobroma-systems.com>

Finally pass the FDT address to TF-A since it now gracefully fallbacks to
hardcoded defaults if it cannot parse it. This allows us to avoid modifying
hardcoded values in TF-A to enable the console.

This was tested with TF-A v2.7.0 on Puma Haikou RK3399.

We do this only for new RK3399 boards, where this will be a conscious choice to
enable CONFIG_SPL_ATF_NO_PLATFORM_PARAM, and Puma since it's been tested with
upstream TF-A. The imply condition on SPL_ATF is always true because SPL_ATF is
selected for all RK3399-based boards in arch/arm/mach-rockchip/Kconfig.

For board maintainers who received this mail, this patch series does not modify
anything for your board. However, this highlights that your board does not make
use of a feature (passing U-Boot DTB to TF-A) I find useful. I know this has
been a pain point for some of you since TF-A has a default baudrate of 115200 on
UART2 for its debug console which meant you had the choice of:
 1) patch TF-A to run at 1500000 baudrate instead (Rockchip's BSP default)
    and/or a different UART controller than UART2,
 2) not have TF-A output,

You're now aware there's a third choice: disable SPL_ATF_NO_PLATFORM_PARAM
Kconfig option if your TF-A is of version 2.4 or newer. Up to you to send a
patch for your board defconfig.

This option was not disabled on all platforms on purpose since Kever prefers to
be careful since some boards might require downstream/blob-only TF-A that are
older than 2.4 version.

To: Simon Glass <sjg at chromium.org>
To: Philipp Tomsich <philipp.tomsich at vrull.eu>
To: Kever Yang <kever.yang at rock-chips.com>
To: Alper Nebi Yasak <alpernebiyasak at gmail.com>
To: Andy Yan <andy.yan at rock-chips.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
To: Nick Xie <nick at khadas.com>
To: Jagan Teki <jagan at amarulasolutions.com>
To: Deepak Das <deepakdas.linux at gmail.com>
To: Alexandre Vicenzi <linux at alxd.me>
To: Xiaobo Tian <peterwillcn at gmail.com>
To: Peter Robinson <pbrobinson at gmail.com>
To: Klaus Goger <klaus.goger at theobroma-systems.com>
To: Levin Du <djw at t-chip.com.cn>
To: Suniel Mahesh <sunil at amarulasolutions.com>
To: Akash Gajjar <akash at openedev.com>
Cc: Hugh Cole-Baker <sigmaris at gmail.com>
Cc: Walter Lozano <walter.lozano at collabora.com>
Cc: Quentin Schulz <foss+uboot at 0leil.net>
Cc: u-boot at lists.denx.de
Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
Changes in v2:
- keep the option selected for existing boards except Puma,
- added board maintainers to recipients of this mail,
- Link to v1: https://lore.kernel.org/r/20221114-rk3399-tf-a-plat-param-v1-0-0f873897bda7@theobroma-systems.com

Quentin Schulz (2):
      rockchip: rk3399: pass platform parameter to TF-A by default for new RK3399 boards
      rockchip: puma: pass platform parameter to TF-A

 arch/arm/mach-rockchip/Kconfig               | 1 -
 configs/chromebook_bob_defconfig             | 1 +
 configs/chromebook_kevin_defconfig           | 1 +
 configs/eaidk-610-rk3399_defconfig           | 1 +
 configs/evb-rk3399_defconfig                 | 1 +
 configs/ficus-rk3399_defconfig               | 1 +
 configs/firefly-rk3399_defconfig             | 1 +
 configs/khadas-edge-captain-rk3399_defconfig | 1 +
 configs/khadas-edge-rk3399_defconfig         | 1 +
 configs/khadas-edge-v-rk3399_defconfig       | 1 +
 configs/leez-rk3399_defconfig                | 1 +
 configs/nanopc-t4-rk3399_defconfig           | 1 +
 configs/nanopi-m4-2gb-rk3399_defconfig       | 1 +
 configs/nanopi-m4-rk3399_defconfig           | 1 +
 configs/nanopi-m4b-rk3399_defconfig          | 1 +
 configs/nanopi-neo4-rk3399_defconfig         | 1 +
 configs/nanopi-r4s-rk3399_defconfig          | 1 +
 configs/orangepi-rk3399_defconfig            | 1 +
 configs/pinebook-pro-rk3399_defconfig        | 1 +
 configs/roc-pc-mezzanine-rk3399_defconfig    | 1 +
 configs/roc-pc-rk3399_defconfig              | 1 +
 configs/rock-pi-4-rk3399_defconfig           | 1 +
 configs/rock-pi-4c-rk3399_defconfig          | 1 +
 configs/rock-pi-n10-rk3399pro_defconfig      | 1 +
 configs/rock960-rk3399_defconfig             | 1 +
 configs/rockpro64-rk3399_defconfig           | 1 +
 26 files changed, 25 insertions(+), 1 deletion(-)
base-commit: 582e3c9fb2337c2f49faa73ac86dde25f4d56901
change-id: 20221114-rk3399-tf-a-plat-param-3ab055f40b9e

Best regards,
Quentin Schulz <quentin.schulz at theobroma-systems.com>

More information about the U-Boot mailing list