[PATCH v2 4/9] dt-bindings: reset: add sama7g5 definitions

[Marek Vasut]

On 1/3/23 17:35, Sergiu.Moga at microchip.com wrote:
> On 03.01.2023 17:59, Marek Vasut wrote:
>> On 1/3/23 16:55, Sergiu.Moga at microchip.com wrote:
>>> On 03.01.2023 17:48, Marek Vasut wrote:
>>>> On 1/3/23 16:35, Sergiu Moga wrote:
>>>>> Upstream linux commit 5994f58977e0.
>>>>>
>>>>> Add reset bindings for SAMA7G5. At the moment only USB PHYs are
>>>>> included.
>>>>>
>>>>> Signed-off-by: Sergiu Moga <sergiu.moga at microchip.com>
>>>>> ---
>>>>>
>>>>> v1 -> v2:
>>>>> - nothing
>>>>>
>>>>>
>>>>>     include/dt-bindings/reset/sama7g5-reset.h | 10 ++++++++++
>>>>>     1 file changed, 10 insertions(+)
>>>>>     create mode 100644 include/dt-bindings/reset/sama7g5-reset.h
>>>>>
>>>>> diff --git a/include/dt-bindings/reset/sama7g5-reset.h
>>>>> b/include/dt-bindings/reset/sama7g5-reset.h
>>>>> new file mode 100644
>>>>> index 0000000000..2116f41d04
>>>>> --- /dev/null
>>>>> +++ b/include/dt-bindings/reset/sama7g5-reset.h
>>>>> @@ -0,0 +1,10 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>> +
>>>>> +#ifndef __DT_BINDINGS_RESET_SAMA7G5_H
>>>>> +#define __DT_BINDINGS_RESET_SAMA7G5_H
>>>>> +
>>>>> +#define SAMA7G5_RESET_USB_PHY1               4
>>>>> +#define SAMA7G5_RESET_USB_PHY2               5
>>>>> +#define SAMA7G5_RESET_USB_PHY3               6
>>>>
>>>> Is there no reset with ID 0/1/2/3 ?
>>>
>>> No, there is not.
>>
>> Please just add a comment into the file then, explaining that.
> 
> 
> Would this not make the commit different from the upstream linux commit
> referenced in the commit message? Perhaps it would be better to place
> this comment in the commit message instead?

That works too, thanks.