[PATCH 1/6] ARM: dts: sam9x60: Add OHCI and EHCI DT nodes

[Eugen.Hristev at microchip.com]

On 1/3/23 01:12, Marek Vasut wrote:
> On 12/23/22 13:33, Sergiu Moga wrote:
>> Add the OHCI and EHCI DT nodes for the sam9x60 boards.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga at microchip.com>
>> ---
>>   arch/arm/dts/at91-sam9x60_curiosity.dts | 21 +++++++++++++++++++++
>>   arch/arm/dts/sam9x60.dtsi               | 18 ++++++++++++++++++
> 
> Board and SoC DT changes should be in separate patches.
> 
>>   arch/arm/dts/sam9x60ek.dts              | 21 +++++++++++++++++++++
>>   3 files changed, 60 insertions(+)
> 
> 
> [...]
> 
>> diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi
>> index 17224ef771..e36a540f78 100644
>> --- a/arch/arm/dts/sam9x60.dtsi
>> +++ b/arch/arm/dts/sam9x60.dtsi
>> @@ -69,6 +69,24 @@
>>               #size-cells = <1>;
>>               ranges;
>>
>> +             usb1: ohci at 600000 {
> 
> This should be usb@ instead of ohci@ , if you run "make dtbs_check" on
> this DT in Linux (please do), you would likely get a warning , see Linux
> Documentation/devicetree/bindings/usb/usb.yaml .


If in Linux we have ohci@ , then we need to have the same in U-boot.
We can accept the change to usb@ , if there is a pending patch in Linux.
U-boot is not the place to review the devicetree. The devicetree must be 
in sync with Linux.

Eugen

> 
>> +                     compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>> +                     reg = <0x00600000 0x100000>;
>> +                     clocks = <&pmc PMC_TYPE_PERIPHERAL 22>, <&pmc 
>> PMC_TYPE_PERIPHERAL 22>, <&pmc PMC_TYPE_SYSTEM 21>;
>> +                     clock-names = "ohci_clk", "hclk", "uhpck";
>> +                     status = "disabled";
>> +             };
> 
> [...]
>