[PATCH 0/3] tpm: Support boot measurements

Simon Glass sjg at chromium.org
Wed Jan 4 21:01:43 CET 2023


Hi Eddie,

On Wed, 4 Jan 2023 at 07:55, Eddie James <eajames at linux.ibm.com> wrote:
>
>
> On 1/4/23 01:47, Ilias Apalodimas wrote:
> > Hi Eddie,
> > Thanks for the patch
> >
> > Looking at the patch there's a lot of code duplication with
> > lib/efi_loader/efi_tcg2.c.
> > Any reason why we aren't reusing that ?
>
>
> Hi,
>
> Well the EFI code can't be used directly without configuring to include
> the EFI subsystem and exporting a bunch of those functions in a header
> file somewhere, so I added the functions in the generic tpm librrary.
> Now it's a matter of doing the work to use the generic functions in the
> EFI system. I can do that in this series if necesssary, I just haven't
> gotten to it.

We cannot have EFI code in tpm-v2.h

The TPM layer should implement the feature, with the EFI layer calling
into it. This allows the TPM feature to be used by VBE and other
non-EFI systems.

Regards,
Simon


More information about the U-Boot mailing list