[PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

[Tom Rini]

On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár wrote:
> On Friday 06 January 2023 10:51:43 Tom Rini wrote:
> > This reverts commit 777aaaa706bcfe08c284aed06886db7d482af3f8.
> > 
> > The changes to this generic function, which is intended to help with
> > 32bit platforms with large amounts of memory has unintended side effects
> > (which in turn lead to boot failures) on other platforms which were
> > previously functional.
> 
> As mentioned previously, unfortunately this revert breaks 32-bit u-boot
> on 36-bit mpc85xx boards with 32-bit e500v2 cores and 4GB DDR module.
> 
> Which platforms currently have broken u-boot without this revert? The
> only one which was reported is stm32mp but for it there different
> workaround patch waiting in the queue.

Are you able to test on one of these PowerPC platforms currently?  As
the stm32 problem shows, not everything is getting tested frequently
enough, so how many other cases are lurking out there.  And, I think
overall issue is that the overflow check-and-change you introduce here
should just be in the CONFIG_MAX_MEM_MAPPED==true case.  As that's the
case you're dealing with, yes?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230106/b6817bcb/attachment.sig>