[PATCH] ARM: omap3: evm: Name this directory omap3

[Andrew Davis]

On 10/7/22 10:21 PM, Derald Woods wrote:
> On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote:
>> Before this was named just evm, which doesn't match the naming
>> of the other TI board file directory and makes it look like a
>> common directory for evms. Name this omap3.
>>
>> Signed-off-by: Andrew Davis <afd at ti.com>
>> ---
>>   arch/arm/mach-omap2/omap3/Kconfig   | 2 +-
>>   board/ti/{evm => omap3}/Kconfig     | 2 +-
>>   board/ti/{evm => omap3}/MAINTAINERS | 2 +-
>>   board/ti/{evm => omap3}/Makefile    | 0
>>   board/ti/{evm => omap3}/evm.c       | 0
>>   board/ti/{evm => omap3}/evm.h       | 0
>>   6 files changed, 3 insertions(+), 3 deletions(-)
>>   rename board/ti/{evm => omap3}/Kconfig (87%)
>>   rename board/ti/{evm => omap3}/MAINTAINERS (87%)
>>   rename board/ti/{evm => omap3}/Makefile (100%)
>>   rename board/ti/{evm => omap3}/evm.c (100%)
>>   rename board/ti/{evm => omap3}/evm.h (100%)
>>
>> diff --git a/arch/arm/mach-omap2/omap3/Kconfig b/arch/arm/mach-omap2/omap3/Kconfig
>> index 3e97ec2629..4e9924faf7 100644
>> --- a/arch/arm/mach-omap2/omap3/Kconfig
>> +++ b/arch/arm/mach-omap2/omap3/Kconfig
>> @@ -163,7 +163,7 @@ config SYS_SOC
>>   source "board/logicpd/am3517evm/Kconfig"
>>   source "board/ti/beagle/Kconfig"
>>   source "board/timll/devkit8000/Kconfig"
>> -source "board/ti/evm/Kconfig"
>> +source "board/ti/omap3/Kconfig"
>>   source "board/isee/igep00x0/Kconfig"
>>   source "board/logicpd/omap3som/Kconfig"
>>   source "board/nokia/rx51/Kconfig"
>> diff --git a/board/ti/evm/Kconfig b/board/ti/omap3/Kconfig
>> similarity index 87%
>> rename from board/ti/evm/Kconfig
>> rename to board/ti/omap3/Kconfig
>> index 4f490ddd9d..d60b229a4e 100644
>> --- a/board/ti/evm/Kconfig
>> +++ b/board/ti/omap3/Kconfig
>> @@ -1,7 +1,7 @@
>>   if TARGET_OMAP3_EVM
>>
>>   config SYS_BOARD
>> -     default "evm"
>> +     default "omap3"
>>
>>   config SYS_VENDOR
>>        default "ti"
>> diff --git a/board/ti/evm/MAINTAINERS b/board/ti/omap3/MAINTAINERS
>> similarity index 87%
>> rename from board/ti/evm/MAINTAINERS
>> rename to board/ti/omap3/MAINTAINERS
>> index cd315c1635..95b34bbd11 100644
>> --- a/board/ti/evm/MAINTAINERS
>> +++ b/board/ti/omap3/MAINTAINERS
>> @@ -1,6 +1,6 @@
>>   EVM BOARD
>>   M:   Derald D. Woods <woods.technical at gmail.com>
>>   S:   Maintained
>> -F:   board/ti/evm/
>> +F:   board/ti/omap3/
>>   F:   include/configs/omap3_evm.h
>>   F:   configs/omap3_evm_defconfig
>> diff --git a/board/ti/evm/Makefile b/board/ti/omap3/Makefile
>> similarity index 100%
>> rename from board/ti/evm/Makefile
>> rename to board/ti/omap3/Makefile
>> diff --git a/board/ti/evm/evm.c b/board/ti/omap3/evm.c
>> similarity index 100%
>> rename from board/ti/evm/evm.c
>> rename to board/ti/omap3/evm.c
>> diff --git a/board/ti/evm/evm.h b/board/ti/omap3/evm.h
>> similarity index 100%
>> rename from board/ti/evm/evm.h
>> rename to board/ti/omap3/evm.h
>> --
>> 2.37.3
>>
> 
> It seems to me that something like 'omap3evm' would be more appropriate
> for a directory name. Using just 'omap3' may be too generic. The actual
> EVM configurations are TMDSEVM3530 [1] and TMDSEVM3730 [2], with the
> corresponding processor boards attached. It would also align with the
> TARGET_OMAP3_EVM definition still in use. These are my observations.
> 

I'm not sure about that, the convention seems to be the directory name
matches the SoC, then the source files match for each type/name of
board. This is at least true for some newer TI boards, but I agree it
is not always followed for the older devices. I have no strong preference
either way, just as long as we can not call it "board/ti/evm" like it
is now..

This patch still applies to the latest u-boot, or I can send a v2.

Andrew

> - Derald
> 
> [1] https://www.digikey.com/en/products/detail/texas-instruments/TMDSEVM3530/2232584
> [2] https://www.digikey.com/en/products/detail/texas-instruments/TMDSEVM3730/2627669
> [3] https://media.digikey.com/pdf/Data%20Sheets/Texas%20Instruments%20PDFs/tmdsevm3730.pdf
> [4] https://media.digikey.com/pdf/Data%20Sheets/Texas%20Instruments%20PDFs/TMDSEVM3530.pdf