[PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default

[Michal Simek]

On 1/9/23 15:13, Tom Rini wrote:
> On Mon, Jan 09, 2023 at 09:56:30AM +0100, Luca Ceresoli wrote:
>> Hello Tom, Simon, Michal,
>>
>> On Sun, 8 Jan 2023 12:36:15 -0700
>> Simon Glass <sjg at chromium.org> wrote:
>>
>>> Hi Tom,
>>>
>>> On Sun, 8 Jan 2023 at 09:24, Tom Rini <trini at konsulko.com> wrote:
>>>>
>>>> On Sun, Jan 08, 2023 at 09:20:09AM -0700, Simon Glass wrote:
>>>>> Hi Tom,
>>>>>
>>>>> On Sun, 8 Jan 2023 at 09:06, Tom Rini <trini at konsulko.com> wrote:
>>>>>>
>>>>>> On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote:
>>>>>>> Hi Tom,
>>>>>>>
>>>>>>> On Sun, 8 Jan 2023 at 06:41, Tom Rini <trini at konsulko.com> wrote:
>>>>>>>>
>>>>>>>> On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wrote:
>>>>>>>>   
>>>>>>>>> This option is deprecated and only used by two boards. Enable it for just
>>>>>>>>> those two boards, so others don't accidentally enable it.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>>>>>> [snip]
>>>>>>>>> diff --git a/boot/Kconfig b/boot/Kconfig
>>>>>>>>> index 55f06761ef8..7ab0dd14211 100644
>>>>>>>>> --- a/boot/Kconfig
>>>>>>>>> +++ b/boot/Kconfig
>>>>>>>>> @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE
>>>>>>>>>   config USE_SPL_FIT_GENERATOR
>>>>>>>>>        bool "Use a script to generate the .its script"
>>>>>>>>>        depends on SPL_FIT
>>>>>>>>> -     default y if SPL_FIT && ARCH_ZYNQMP
>>>>>>>>> +     help
>>>>>>>>> +       This is deprecated. Please do not use it. Use binman instead.
>>>>>>>>
>>>>>>>> Lets remove the text around bool so it can't be enabled, and move to
>>>>>>>> select'ing it from the two boards that need it. Michal, Luca, what's
>>>>>>>> needed to move your two platforms
>>>>>>>> (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_zynqmp_virt off
>>>>>>>> of this very legacy option, given that other xilinx platforms have
>>>>>>>> already migrated to binman ?
>>
>> Unfortunately I lost access to that board, and since the vendor does
>> not appear interested in supporting it I think the best options would
>> be to either remove the defconfig or to keep legacy support.
>>
>> Which one would you prefer?
> 
> If the vendor doesn't want to support it, and no one can test it, it
> should get dropped I think. Michal, do you have anything to add here?
> 

I don't have access to this board too.

I don't think there is a need to have separate defconfig for it and that board 
should be already covered by xilinx_zynqmp_virt_defconfig.
It means we can just remove defconfig and keep dts and psu_init* in the tree and 
I believe it will work fine as before.

Or of course remove it completely if none is wiling to support it.

Thanks,
Michal