[PATCH] imx8mm-phg: Add board support
Tom Rini
trini at konsulko.com
Mon Jan 9 21:39:03 CET 2023
On Mon, Jan 09, 2023 at 04:35:07PM -0300, Fabio Estevam wrote:
> Hi Tom,
>
> On 09/01/2023 16:00, Tom Rini wrote:
>
> > This is going to need to be rebased on top of current master due to
> > CONFIG -> CFG or Kconfig migration. On top of that:
>
> Ok, I will rebase on top of the current master.
>
> > > +#define CONFIG_SYS_SDRAM_BASE 0x40000000
> > > +#define PHYS_SDRAM 0x40000000
> > > +#define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */
> >
> > Please make sure we need to define PHYS_SDRAM* at all. Thanks!
>
> Sorry, I don't understand this comment.
>
> PHYS_SDRAM and PHYS_SDRAM_SIZE are used by arch/arm/mach-imx/imx8m/soc.c.
OK, so those defines are used. There's a surprising amount of unused
defines that end up in include/configs/ so I want to be sure when I see
a new one pop up.
As a tangent, are these actually board specific? My first glance is that
we're just saying where memory could be, rather than is all of memory
and so it should just be a static "starts here, takes up the remaining
2GB of address space".
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230109/aa0dea96/attachment.sig>
More information about the U-Boot
mailing list