[PATCH 2/7] drivers: net: fsl-mc: remove an useless break statement

Ramon Fried rfried.dev at gmail.com
Tue Jan 10 18:05:28 CET 2023


On Thu, Jan 5, 2023 at 5:03 PM Ioana Ciornei <ioana.ciornei at nxp.com> wrote:
>
> The break statement is just after a goto statement, thus it will not get
> executed. Just remove it.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com>
> ---
>  drivers/net/fsl-mc/mc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
> index 66fcb48ebd55..180e57e42266 100644
> --- a/drivers/net/fsl-mc/mc.c
> +++ b/drivers/net/fsl-mc/mc.c
> @@ -1961,7 +1961,6 @@ static int do_fsl_mc(struct cmd_tbl *cmdtp, int flag, int argc,
>         default:
>                 printf("Invalid option: %s\n", argv[1]);
>                 goto usage;
> -               break;
>         }
>         return err;
>   usage:
> --
> 2.25.1
>
It's possible that it's there only to silent dumb compiler who thinks
that break was forgotten.
Let's see if it introduces problems in the CI. meanwhile I'll approve.
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>


More information about the U-Boot mailing list