kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

[Pali Rohár]

On Wednesday 11 January 2023 12:44:45 Tony Dinh wrote:
> Hi Pali,
> 
> On Wed, Jan 11, 2023 at 12:04 AM Pali Rohár <pali at kernel.org> wrote:
> >
> > On Tuesday 10 January 2023 21:07:45 Tony Dinh wrote:
> > > Hi Pali,
> > >
> > > I got burned for being lazy :) it turned out that the mix of #ifdef
> > > and #if defined was the problem. Just stepped away and came back for a
> > > few minutes and I can see that I just need to define the CONFIG_DDR4
> > > properly in arch/arm/mach-mvebu/Kconfig and build it to pass the
> > > CONFIG_DDR4 stuff.
> > >
> > > One more small hurdle after that was CONFIG_USE_PRIVATE_LIBGCC must be
> > > undefined for it to build (so I am using
> > > /usr/lib/gcc/arm-linux-gnueabi/10/libgcc.a, and not using
> > > arch/arm/lib/lib.a)
> >
> > Hello! It is normally a good idea to unset CONFIG_USE_PRIVATE_LIBGCC
> > unless you have compiled gcc for target CPU.
> 
> CONFIG_USE_PRIVATE_LIBGCC was set as a default for ARM target, since
> u-boot has arch/arm/lib/lib.a. But using arch/arm/lib/lib.a I got
> several build errors like these:
> 
> ld.bfd: drivers/ddr/marvell/a38x/mv_ddr4_training_calibration.o: in
> function `mv_ddr4_copt_get':
> /usr/src/u-boot/drivers/ddr/marvell/a38x/mv_ddr4_training_calibration.c:809:
> undefined reference to `__aeabi_i2d'
> ld.bfd: /usr/src/u-boot/drivers/ddr/marvell/a38x/mv_ddr4_training_calibration.c:809:
> undefined reference to `__aeabi_dmul'
> ld.bfd: /usr/src/u-boot/drivers/ddr/marvell/a38x/mv_ddr4_training_calibration.c:809:
> undefined reference to `__aeabi_d2uiz'

This looks like a bug in that training code. I would need to see source
code, so I can figure out how to fix it.

> Perhaps this is something that needs to be looked at.
> 
> >
> > > But Marvell DDR4 is working fine! Please see the log.
> >
> > Nice! So you can send patches for that board to list.
> 
> Sure I will for the N2350 board. How will we be handling the Marvell
> DDR code resync?

Send that DDR code resync in one patch... and saying e.g. adding support
for DDR4 from Marvell repo.