[PATCH v3 2/4] ARM: stm32: Factor out save_boot_params

[Patrice CHOTARD]

Hi Marek

On 1/12/23 18:55, Marek Vasut wrote:
> On 1/12/23 16:06, Patrice CHOTARD wrote:
>> Hi Marek
> 
> Hi,
> 
>> I am preparing the next STM32 U-Boot pull request, during testing, buidlman is complaining with the following warning:
>>
>> 03: ARM: stm32: Factor out save_boot_params
>>         arm:  +   stm32mp13
>> +../arch/arm/mach-stm32mp/boot_params.c: In function 'board_fdt_blob_setup':
>> +../arch/arm/mach-stm32mp/boot_params.c:20:35: error: implicit declaration of function 'get_stm32mp_bl2_dtb' [-Werror=implicit-function-declaration]
>> +   20 |         unsigned long nt_fw_dtb = get_stm32mp_bl2_dtb();
>> +      |                                   ^~~~~~~~~~~~~~~~~~~
>> +cc1: all warnings being treated as errors
>>
>>
>> Same issue with stm32mp15_defconfig and stm32mp15_trusted_defconfig.
> 
> Sorry for the inconvenience.
> 
> Does the change below help ?
> If so, can you squash it into 2/4 or do you want v4 ?

Yes the change you proposed is OK.
I saw that you have submitted a v4 including this fix, i will add it to the next U-Boot STM32 PR.

Thanks for your reactivity ;-)

Patrice
> 
> diff --git a/arch/arm/mach-stm32mp/boot_params.c b/arch/arm/mach-stm32mp/boot_params.c
> index e40cca938ef..24d04dcf0f9 100644
> --- a/arch/arm/mach-stm32mp/boot_params.c
> +++ b/arch/arm/mach-stm32mp/boot_params.c
> @@ -8,6 +8,7 @@
>  #include <common.h>
>  #include <log.h>
>  #include <linux/libfdt.h>
> +#include <asm/arch/sys_proto.h>
>  #include <asm/sections.h>
>  #include <asm/system.h>