[PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

[Tom Rini]

On Sat, Jan 14, 2023 at 12:22:24PM -0500, Tom Rini wrote:
> On Sat, Jan 14, 2023 at 11:57:20AM -0500, Tom Rini wrote:
> > On Sat, Jan 14, 2023 at 08:27:25AM -0500, Tom Rini wrote:
> > > On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam wrote:
> > > > Hi Francesco,
> > > > 
> > > > On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini <francesco at dolcini.it> wrote:
> > > > >
> > > > > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > > > >
> > > > > Without the DM_EVENT absolutely no output whatsoever and the system does
> > > > > not boot at all.
> > > > 
> > > > Why do we need to select CONFIG_EVENT=y in the first place?
> > > > 
> > > > Oliver on CC reported the same issue for his board, and we have other
> > > > broken boards too
> > > > that do not select CONFIG_EVENT=y.
> > > > 
> > > > Can we have a generic fix for this?
> > > > 
> > > > Tom, Heinrich?
> > > 
> > > Yes, if someone can explain what the problem is, we can correct the
> > > dependency.  I gather most platforms have whatever this problem is
> > > ignored due to enabling EFI_LOADER.
> > 
> > The more I look at this, the more confused I get. With DEBUG_UART
> > enabled, where do thing fail without CONFIG_EVENT (and CONFIG_DM_EVENT,
> > which is then enabled due to "imply DM_EVENT" in arch/arm/Kconfig, under
> > ARCH_IMX8) ? How about if you turn DM_EVENT back off?
> 
> The only other data point I can add right now is that it's not entirely
> generic, I think. I can disable EFI_LOADER and EVENT and DM_EVENT on
> am65x_evm (both r5 and a53 portions) and still boot up fine. I don't
> have something imx8 in my lab, however.

Wait, no, I finally found it I think:
commit 7fe32b3442f0d0e77a0768dcc1ee65fb352a080a
Author: Simon Glass <sjg at chromium.org>
Date:   Fri Mar 4 08:43:05 2022 -0700

    event: Convert arch_cpu_init_dm() to use events
    
    Instead of a special function, send an event after driver model is inited
    and adjust the boards which use this function.
    
    Signed-off-by: Simon Glass <sjg at chromium.org>

That uses "imply DM_EVENT" when it needs to be using select. I'll post a
patch shortly.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230114/97292c99/attachment.sig>