[PATCH] sunxi: f1c100s: re-enable SYSRESET

Samuel Holland samuel at sholland.org
Sat Jan 14 21:30:55 CET 2023

On 1/4/23 20:04, Andre Przywara wrote:
> The SoC .dtsi originally submitted for the Allwinner F1C100s had the
> wrong compatible string for the watchdog, which broke U-Boot's reset
> functionality. To quickly fix this, we disable CONFIG_SYSRESET in
> cfcf1952c11e6ffcbbf88 ("sunxi: f1c100s: Drop SYSRESET to enable reset
> functionality"), so that U-Boot's hardcoded reset driver could take over.
> After this was properly fixed in the devicetree, we reverted that patch
> in 92373de041ea ("Revert "sunxi: f1c100s: Drop SYSRESET to enable reset
> functionality"), however this line sneaked back in with d0ee7f295d74
> ("Convert CONFIG_SYS_PBSIZE to Kconfig"), so during a Kconfig update.
> Remove this line (again), to use the proper reset driver.
> Fixes: d0ee7f295d74 ("Convert CONFIG_SYS_PBSIZE to Kconfig")
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
> Hi,
> this is not critical (so nothing for 2023.01), reset works either way.
> But we should fix it anyway.
> Cheers,
> Andre
>  configs/licheepi_nano_defconfig | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Samuel Holland <samuel at sholland.org>

More information about the U-Boot mailing list