[PATCH 2/2] event: Correct dependencies on the EVENT framework

[Simon Glass]

Hi Tom,

On Sat, 14 Jan 2023 at 13:49, Tom Rini <trini at konsulko.com> wrote:
>
> The event framework is just that, a framework. Enabling it by itself
> does nothing, so we shouldn't ask the user about it. Reword (and correct
> typos) around this the option and help text. This also applies to
> DM_EVENT, so reword as well.
>
> With this, it's time to address the larger problems. When functionality
> uses events, typically via EVENT_SPY, the appropriate framework then
> must be select'd and NOT imply'd. As the functionality will cease to
> work (and so, platforms will fail to boot) this is non-optional and
> where select is appropriate. Audit the current users of EVENT_SPY to
> have a more fine-grained approach to select'ing the framework where
> used.
>
> Cc: Simon Glass <sjg at chromium.org>
> Reported-by: Oliver Graute <Oliver.Graute at kococonnector.com>
> Reported-by: Francesco Dolcini <francesco.dolcini at toradex.com>
> Fixes: 7fe32b3442f0 ("event: Convert arch_cpu_init_dm() to use events")
> Fixes: 42fdcebf859f ("event: Convert misc_init_f() to use events")
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  arch/Kconfig                     |  6 +++---
>  arch/arm/Kconfig                 |  9 ++++-----
>  arch/arm/mach-omap2/Kconfig      |  3 +++
>  arch/mips/Kconfig                |  2 +-
>  arch/powerpc/cpu/mpc85xx/Kconfig |  1 +
>  arch/x86/Kconfig                 |  1 +
>  arch/x86/cpu/baytrail/Kconfig    |  1 +
>  arch/x86/cpu/broadwell/Kconfig   |  1 +
>  arch/x86/cpu/ivybridge/Kconfig   |  1 +
>  arch/x86/cpu/quark/Kconfig       |  1 +
>  board/google/Kconfig             |  1 +
>  board/keymile/Kconfig            |  1 +
>  boot/Kconfig                     |  1 +
>  cmd/Kconfig                      |  1 +
>  common/Kconfig                   | 17 ++++++++---------
>  drivers/core/Kconfig             |  9 +++++----
>  drivers/cpu/Kconfig              |  1 -

Reviewed-by: Simon Glass <sjg at chromium.org>

Tested on chromebook-coral:
Tested-by: Simon Glass <sjg at chromium.org>

I am not quite sure what the effective difference is between select
and imply. Doesn't this suggest that there are some conflicting config
options? The only way imply would be disabled ( I thought) is if a
board does it explicitly?

Regards,
Simon