[PATCH 2/2] event: Correct dependencies on the EVENT framework

Fabio Estevam festevam at gmail.com
Sun Jan 15 13:29:58 CET 2023


Hi Tom,

On Sat, Jan 14, 2023 at 5:50 PM Tom Rini <trini at konsulko.com> wrote:
>
> The event framework is just that, a framework. Enabling it by itself
> does nothing, so we shouldn't ask the user about it. Reword (and correct
> typos) around this the option and help text. This also applies to
> DM_EVENT, so reword as well.
>
> With this, it's time to address the larger problems. When functionality
> uses events, typically via EVENT_SPY, the appropriate framework then
> must be select'd and NOT imply'd. As the functionality will cease to
> work (and so, platforms will fail to boot) this is non-optional and
> where select is appropriate. Audit the current users of EVENT_SPY to
> have a more fine-grained approach to select'ing the framework where
> used.
>
> Cc: Simon Glass <sjg at chromium.org>
> Reported-by: Oliver Graute <Oliver.Graute at kococonnector.com>
> Reported-by: Francesco Dolcini <francesco.dolcini at toradex.com>
> Fixes: 7fe32b3442f0 ("event: Convert arch_cpu_init_dm() to use events")
> Fixes: 42fdcebf859f ("event: Convert misc_init_f() to use events")
> Signed-off-by: Tom Rini <trini at konsulko.com>

Thanks for investigating and providing a proper fix:

Reviewed-by: Fabio Estevam <festevam at denx.de>


More information about the U-Boot mailing list