[PATCH] ns16550: Fix DM serial operation with non-DM SPL

[Tom Rini]

On Tue, Jan 17, 2023 at 04:12:54PM +0300, Sergei Antonov wrote:
> On Tue, 17 Jan 2023 at 15:10, Andre Przywara <andre.przywara at arm.com> wrote:
> 
> > -#if CONFIG_IS_ENABLED(DM_SERIAL) && !defined(CONFIG_SYS_NS16550_REG_SIZE)
> > +#if CONFIG_IS_ENABLED(DM_SERIAL)
> >  /*
> >   * For driver model we always use one byte per register, and sort out the
> >   * differences in the driver
> >   */
> > +#undef CONFIG_SYS_NS16550_REG_SIZE
> >  #define CONFIG_SYS_NS16550_REG_SIZE (-1)
> >  #endif
> 
> What if I have DM_SERIAL and a 16550 UART with 32-bit registers?
> Before 9591b63531fa the register size of 8 was enforced for DM_SERIAL.

Note that right now, there are some broken cases still, which is why I
made:
https://patchwork.ozlabs.org/project/uboot/patch/20230110161946.3816866-5-trini@konsulko.com/
but that doesn't fix _this_ case, either. Can you test the above patch
on your platform however? Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230117/daca074d/attachment.sig>