[PATCH v3 3/3] ARM: tegra: include timer as default option

[Svyatoslav Ryhel]

вт, 17 січ. 2023 р. о 22:08 Tom Warren <TWarren at nvidia.com> пише:
>
> Svyatoslav,
>
> I was able to apply the first 2 patches OK to TOT u-boot-tegra/master, but not the this one (file offsets seem wrong). PTAL.
>
Thank you very much for your review. This patchset was prepared and
being re-send for 3-4 month, a week or so ago u-boot faced major
kconfig rework, including tegra section. I will adjust this commit in
v4.
>
> I also would like someone who's using or has used T20/T30 lately to take a look, as I haven't had any interaction with those boards or builds for years, and don't know that I can rule on the fitness of these patches. Once they get ACK'd by someone that's still using T20/T30, I can apply them and get a PR in to TomR.
>
That would be quite hard to achieve. It seems that I am maintaining
the biggest group of developers and users of T20/T30 (pmOS on
Transformers). So far we have tested these patches for 4 month on all
T20/T30 Asus Transformers, Google Nexus 7 2012, LG Optimus 4X HD and
Optimus Vu, HTC One X, Surface RT. This should be representative for
ventana, cardhu, kai and enterprise dev boards. Though it is up to
you.
>
> Thanks,
>
> Tom
>
P. S. I would like you to be aware that I am willing to mainline a few
more patch sets to improve Tegra 2 and Tegra 3 along with bringing
many new Tegra based devices into mainline u-boot (estimated total
commit number around 50). Devices I would like to add are roughly
those I have named above.
Best regards, Svyatoslav R.
>
> -----Original Message-----
> From: Svyatoslav Ryhel <clamor95 at gmail.com>
> Sent: Tuesday, January 17, 2023 9:53 AM
> To: Bharat Gooty <bharat.gooty at broadcom.com>; Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>; Tom Warren <twarren at nvidia.com>; Marek Vasut <marex at denx.de>; Svyatoslav Ryhel <clamor95 at gmail.com>; Maxim Schwalm <maxim.schwalm at gmail.com>; Heinrich Schuchardt <xypron.glpk at gmx.de>; Michal Simek <michal.simek at amd.com>; Stefan Roese <sr at denx.de>; Eugen Hristev <eugen.hristev at microchip.com>; Michael Walle <michael at walle.cc>; Simon Glass <sjg at chromium.org>; Jim Liu <jim.t90615 at gmail.com>; William Zhang <william.zhang at broadcom.com>; Rick Chen <rick at andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>; Andre Przywara <andre.przywara at arm.com>; Jaehoon Chung <jh80.chung at samsung.com>
> Cc: u-boot at lists.denx.de
> Subject: [PATCH v3 3/3] ARM: tegra: include timer as default option
>
> External email: Use caution opening links or attachments
>
>
> Enable TIMER as default option for add Tegra devices and enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL part and drop deprecated configs from common header.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> ---
>  arch/arm/Kconfig               | 1 +
>  arch/arm/mach-tegra/Kconfig    | 2 ++
>  include/configs/tegra-common.h | 6 ------
>  3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 3f68d0988b..4fce820350 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1334,6 +1334,7 @@ config ARCH_TEGRA
>         select GPIO_EXTRA_HEADER
>         imply DISTRO_DEFAULTS
>         imply FAT_WRITE
> +       imply SPL_TIMER if SPL
>
>  config ARCH_VEXPRESS64
>         bool "Support ARMv8 Arm Ltd. VExpress based boards and models"
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 1bef2fb233..173be3c439 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -62,6 +62,7 @@ config TEGRA_COMMON
>         select MISC
>         select OF_CONTROL
>         select SPI
> +       select TIMER
>         imply CMD_DM
>         imply CRC32_VERIFY
>
> @@ -87,6 +88,7 @@ config TEGRA_ARMV7_COMMON
>         select TEGRA_NO_BPMP
>         select TEGRA_PINCTRL
>         select TEGRA_PMC
> +       select TEGRA_TIMER
>
>  config TEGRA_ARMV8_COMMON
>         bool "Tegra 64-bit common options"
> diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index 2915db7f8b..390a2387ea 100644
> --- a/include/configs/tegra-common.h
> +++ b/include/configs/tegra-common.h
> @@ -15,12 +15,6 @@
>
>  #include <asm/arch/tegra.h>            /* get chip and board defs */
>
> -/* Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. */ -#ifndef CONFIG_ARM64
> -#define CONFIG_SYS_TIMER_RATE          1000000
> -#define CONFIG_SYS_TIMER_COUNTER       NV_PA_TMRUS_BASE
> -#endif
> -
>  /* Environment */
>
>  /*
> --
> 2.37.2
>