[v3 2/2] event: Correct dependencies on the EVENT framework
Tom Rini
trini at konsulko.com
Thu Jan 19 15:46:22 CET 2023
On Mon, Jan 16, 2023 at 03:46:49PM -0500, Tom Rini wrote:
> The event framework is just that, a framework. Enabling it by itself
> does nothing, so we shouldn't ask the user about it. Reword (and correct
> typos) around this the option and help text. This also applies to
> DM_EVENT and EVENT_DYNAMIC. Only EVENT_DEBUG and CMD_EVENT should be
> visible to the user to select, when EVENT is selected.
>
> With this, it's time to address the larger problems. When functionality
> uses events, typically via EVENT_SPY, the appropriate framework then
> must be select'd and NOT imply'd. As the functionality will cease to
> work (and so, platforms will fail to boot) this is non-optional and
> where select is appropriate. Audit the current users of EVENT_SPY to
> have a more fine-grained approach to select'ing the framework where
> used. Also ensure the current users of event_register and also select
> EVENT_DYNAMIC.
>
> Cc: AKASHI Takahiro <takahiro.akashi at linaro.org>
> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reported-by: Oliver Graute <Oliver.Graute at kococonnector.com>
> Reported-by: Francesco Dolcini <francesco.dolcini at toradex.com>
> Fixes: 7fe32b3442f0 ("event: Convert arch_cpu_init_dm() to use events")
> Fixes: 42fdcebf859f ("event: Convert misc_init_f() to use events")
> Fixes: c5ef2025579e ("dm: fix DM_EVENT dependencies")
> Signed-off-by: Tom Rini <trini at konsulko.com>
> Tested-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Fabio Estevam <festevam at denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230119/db91a2e9/attachment.sig>
More information about the U-Boot
mailing list